Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iOS Shell Tests (still no CI <3) #7110

Merged
merged 7 commits into from May 13, 2022
Merged

Fix iOS Shell Tests (still no CI <3) #7110

merged 7 commits into from May 13, 2022

Conversation

PureWeen
Copy link
Member

Description of Change

  • Fix up the iOS Shell tests so they all pass.
  • I've setup the Shell tests to run in a separate presented VC because that causes all the life cycle and layout events to fire in a more predictable way for a shell app
  • The tests still don't pass on CI :-/ but they at least all run locally

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Eilon Eilon added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label May 13, 2022
@Redth Redth merged commit 36eed28 into main May 13, 2022
@Redth Redth deleted the ios_fix_shell_tests branch May 13, 2022 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Redth approved these changes

Assignees
No one assigned
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout t/housekeeping ♻︎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PureWeen @jsuarezruiz @Redth @Eilon